Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: crash on empty dialog extensions array on Windows #48640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: crash on empty dialog extensions array on Windows #48640

wants to merge 1 commit into from
+11 −7

Conversation

@codebytere
Copy link
Member

Description of Change

Closes #48611

Fixes a crash caused by the following:

out_of_range was thrown in -fno-exceptions mode with message "basic_string"

Due to a stricter -fno-exceptions introduced in Chromium via v33.2.0...v33.2.1.

Checklist

Release Notes

Notes: Fixed a potential crash in dialog.showOpenDialog on Windows with an empty extension filter array.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. labels Oct 23, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 23, 2025
deepak1556
deepak1556 reviewed Oct 23, 2025
View reviewed changes
@codebytere codebytere force-pushed the fix-window-ext-crash branch from 6ff9609 to cb1d71a Compare October 23, 2025 11:13
@codebytere codebytere requested a review from deepak1556 October 23, 2025 13:32
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@dsanders11 dsanders11 Awaiting requested review from dsanders11

Assignees

No one assigned

Labels

semver/patch backwards-compatible bug fixes target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dialog.showOpenDialog() with extensions: [] makes app crash in Windows

2 participants

@codebytere @deepak1556