Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: only call popup closecallback for top-level menu#49017

Merged
jkleinsc merged 1 commit intomainfrom
fix-menu-close-submenu
Nov 21, 2025
Merged

fix: only call popup closecallback for top-level menu#49017
jkleinsc merged 1 commit intomainfrom
fix-menu-close-submenu

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Nov 19, 2025

Description of Change

Closes #49005.

Fixes an issue where the close callback param for menu.popup would fire when any arbitrary submenu of the given menu closed, and not the menu itself.

Fix this by ensuring that menuDidClose checks for the menu being the correc top-level menu.

Checklist

Release Notes

Notes: Fixed an issue where the close callback param for menu.popup would fire when any arbitrary submenu of the given menu closed, and not the menu itself.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. labels Nov 19, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 19, 2025
@codebytere codebytere requested a review from jkleinsc November 19, 2025 17:23
@jkleinsc
Copy link
Member

jkleinsc commented Nov 19, 2025

@codebytere can you rebase this? That should resolve the datadog failure.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 20, 2025
@codebytere codebytere force-pushed the fix-menu-close-submenu branch from b74b658 to 90b4e8a Compare November 20, 2025 09:34
@jkleinsc jkleinsc merged commit e4f02fa into main Nov 21, 2025
145 of 152 checks passed
@jkleinsc jkleinsc deleted the fix-menu-close-submenu branch November 21, 2025 15:37
@release-clerk
Copy link

release-clerk bot commented Nov 21, 2025

Release Notes Persisted

Fixed an issue where the close callback param for menu.popup would fire when any arbitrary submenu of the given menu closed, and not the menu itself.

This was referenced Nov 21, 2025
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 21, 2025

I have automatically backported this PR to "39-x-y", please check out #49045

@trop
Copy link
Contributor

trop bot commented Nov 21, 2025

I have automatically backported this PR to "40-x-y", please check out #49046

@trop trop bot removed the target/39-x-y PR should also be added to the "39-x-y" branch. label Nov 21, 2025
@trop
Copy link
Contributor

trop bot commented Nov 21, 2025

I have automatically backported this PR to "38-x-y", please check out #49047

@trop trop bot added in-flight/40-x-y in-flight/38-x-y merged/38-x-y PR was merged to the "38-x-y" branch. and removed target/40-x-y PR should also be added to the "40-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. in-flight/38-x-y labels Nov 21, 2025
@trop trop bot added merged/40-x-y PR was merged to the "40-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. and removed in-flight/40-x-y in-flight/39-x-y labels Nov 23, 2025
@codebytere codebytere mentioned this pull request Nov 25, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

Assignees

No one assigned

Labels

merged/38-x-y PR was merged to the "38-x-y" branch. merged/39-x-y PR was merged to the "39-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Menu.popup options callback will be called when sub menu close

2 participants

@codebytere @jkleinsc