-
-
Notifications
You must be signed in to change notification settings - Fork 0
Show #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Change supply method visibility to private in Logger.java - Update project version to 7.0.0 in pom.xml - Adjust JDK requirement in README for version 7.0.0 and above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR appears to make a significant API change to the ELF4J logging facade library, involving a major version bump from 6.0.4 to 7.0.0 and raising the minimum Java version requirement from 8 to 11.
- Updated minimum Java version from 8 to 11 for versions 7.0.0 and above
- Made the
supplymethod private instead of package-private - Removed extensive Javadoc comments from the Logger interface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pom.xml | Bumped version to 7.0.0 and updated compiler target to Java 11 |
| src/main/java/elf4j/Logger.java | Changed supply method visibility to private and removed Javadoc |
| README.md | Updated Java version requirements documentation and added new convenience methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.