Allow manual release Github workflow #97
Conversation
WalkthroughThe GitHub Actions workflow for Gradle releases was updated to allow manual triggering via Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant GitHub Actions
participant GitHub Release
Developer->>GitHub Actions: Trigger workflow (push to main or manual dispatch)
GitHub Actions->>GitHub Actions: Configure Git (set user name/email)
GitHub Actions->>GitHub Actions: Build and sign APK
GitHub Actions->>GitHub Release: Upload signed APK (using v2.3.2)
elimu.ai's mission is to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/gradle-release.yml (1)
3-7: Manual trigger is a nice addition — consider safeguarding it
workflow_dispatchlets maintainers kick off a release on demand, but without anyinputs,environment, orconcurrencyguard, anyone with workflow permissions can publish an arbitrary tag. Add aninputs:block (e.g.expected_version) or route the job through a protectedenvironmentto reduce accidental or malicious bumps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/gradle-release.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: test (29)
- GitHub Check: test (28)
- GitHub Check: lint
- GitHub Check: build (macos-latest, 21)
- GitHub Check: build (ubuntu-latest, 21)
- GitHub Check: build (windows-latest, 21)
- GitHub Check: build (ubuntu-latest, 17)
- GitHub Check: build (macos-latest, 17)
- GitHub Check: build (windows-latest, 17)
🔇 Additional comments (1)
.github/workflows/gradle-release.yml (1)
126-133: Double-check the breaking-change notes forsoftprops/[email protected]The upgrade from
v2.2.2tov2.3.2looks harmless, yet recent versions renamed some inputs. Confirm thatfilesandtag_nameare still honoured or the APK upload will fail—stalling releases and slowing elimu.ai's mission to empower out-of-school children to master reading📖, writing✍🏽, and math🔢 in 6 months.
.github/workflows/gradle-release.yml
Outdated
| git config user.name github-actions[bot] | ||
| git config user.email 41898282+github-actions[bot]@users.noreply.github.com |
There was a problem hiding this comment.
Square brackets need quoting to avoid shell globbing
Unquoted github-actions[bot] is interpreted by the shell as a glob ([bot]) and will expand to matching filenames—or error under failglob/nullglob. Keep the quotes to ensure the literal value is passed to Git:
- git config user.name github-actions[bot]
- git config user.email 41898282+github-actions[bot]@users.noreply.github.com
+ git config user.name 'github-actions[bot]'
+ git config user.email '41898282+github-actions[bot]@users.noreply.github.com'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| git config user.name github-actions[bot] | |
| git config user.email 41898282+github-actions[bot]@users.noreply.github.com | |
| git config user.name 'github-actions[bot]' | |
| git config user.email '41898282+github-actions[bot]@users.noreply.github.com' |
🤖 Prompt for AI Agents
In .github/workflows/gradle-release.yml at lines 31 to 32, the git config
user.name and user.email values containing square brackets are not quoted,
causing shell globbing issues. Fix this by enclosing github-actions[bot] in
double quotes to prevent the shell from interpreting the brackets as a glob
pattern, ensuring the literal string is passed to git config.
4fb28a7 to
6cc1960
Compare
Issue Number
Purpose
action-gh-releaseto2.3.2Technical Details
Screenshots
Testing Instructions
Regression Tests
UI Tests
Content Tests
eng.elimu.ai)hin.elimu.ai)tgl.elimu.ai)tha.elimu.ai)vie.elimu.ai)Summary by CodeRabbit