Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Value space consumption optimization #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2021
Merged

Value space consumption optimization #7

merged 6 commits into from
Aug 4, 2021

Conversation

@Terisback
Copy link
Contributor

@Terisback Terisback commented Aug 3, 2021 •
edited
Loading

Achieved by using unions

This change is Reviewable

elliotchance
elliotchance requested changes Aug 3, 2021
View reviewed changes
@Terisback
Copy link
Contributor Author

Terisback commented Aug 4, 2021 •
edited
Loading

Last commit uses union compare, rn can't check what code it generates,
and tests not so representable because of only one type tested
It needs investigation, does it work right or not

@elliotchance elliotchance merged commit 4dc678f into elliotchance:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliotchance elliotchance elliotchance approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Terisback @elliotchance