Implement a destroyApp helper. #4772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifically, this came up with ember-cli-mirage. We need to shutdown the pretender server via With this change, we'd be able to edit the |
|
If this gets accepted, I'll go ahead and update ember-cli-mocha to utilize it, too. |
7098363 to
575b44c
Compare
This is similar to startApp, and is very simple for the time being. However, this allows addon authors to hook into when the app is destroyed in a testing environment.
575b44c to
83b9aba
Compare
|
LGTM 👍 |
stefanpenner
added a commit
that referenced
this pull request
Sep 9, 2015
Implement a destroyApp helper.
|
Simple and clever 👍 |
This was referenced Sep 20, 2015
|
I have an open PR on ember-watson to assist folks in migrating their old acceptance tests to use the new helper. |
|
@blimmer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to startApp, and is very simple for the time being. However, this allows addon authors to hook into when the app is destroyed in a testing environment.