Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@GavinJoyce
Copy link
Member

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using ember-watson, and giving it access to the HTMLBars AST transforms etc seems like a reason path forward.

@ef4
Copy link
Contributor

ef4 commented Oct 2, 2015

I think ember-watson is the right place to solve the problems you're describing.

Last I knew, the barrier to doing htmlbars rewriting was creating a whitespace-preserving AST printer. We actually already implement some of the transformations you'd want, they just happen at compile time now, and can't be easily printed back out as template files.

@GavinJoyce
Copy link
Member Author

Fair enough, I'll close this and contribute to ember-watson.

Perhaps we can revisit this once it has more comprehensive coverage of depreciations? It would be nice to explicitly include new depreciations in ember-watson as part of the depreciation process, include links in the depreciation documentation and possibly include ember-watson in ember-cli

@GavinJoyce GavinJoyce closed this Oct 5, 2015
@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2015

I don't think we will block new deprecations from being added on having automated upgrade tooling, but we definitely are blocking deprecations without an entry in the deprecation guide for the version in question. My goal would be to ensure that this guide has all the info required for someone to be able to add upgrade automation to ember-watson.

@GavinJoyce
Copy link
Member Author

@rwjblue Sounds good, thanks

@GavinJoyce
Copy link
Member Author

The first of many (hopefully): abuiles/ember-watson#87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants