Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@emilevr
Copy link
Owner

@emilevr emilevr commented Oct 21, 2023

Describe your changes

  • Removes the show-timing arg and replace that with a new binary space-bench which can be used by maintainers and workflows to compare perf against previous version.
  • Small navigation improvement where the + key now expands the selected item if it is collapsed and shows the children as collapsed.

PR requirements

  • I have followed the guidelines in the Contribution Guide document.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • I have confirmed locally that there are no linting issues.
  • I have confirmed that all tests pass locally.
  • I have confirmed that my changes do not negatively impact performance by manually comparing before and
    after performance against a suitable local directory tree.
  • I have confirmed that code coverage has not regressed as a result of my changes.

@emilevr emilevr merged commit ebb6f5b into main Oct 21, 2023
@emilevr emilevr deleted the feat/emilevr/space-bench branch October 21, 2023 14:21
emilevr added a commit that referenced this pull request Oct 27, 2023
* Update PR template and README
* Remove show-timing arg and move functionality to space-bench binary
* Update docs
* Test workflow triggers
* Test workflow triggers
* Update key help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants