Fix: ctx.set_fonts() Doesn't Apply Fonts with Same Name #5345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5345-patch146 |
|
I agree with the suggestion to remove the comparison check in However, I'm not entirely convinced about the need for real-time updates (applying fonts immediately). While real-time updates might be useful in some scenarios, the current behavior of applying changes in the next frame is generally sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: ctx.set_fonts() Doesn't Apply Fonts with Same Name
If a font file named
my_fontis set usingctx.set_fonts()and then another font file with the same name is set again usingctx.set_fonts(), it won't be applied.ctx.set_fonts().resetthefontsandtexture.ctx.set_fonts()Doesn't Apply Fonts with Same Name #5252ctx.set_fonts()Doesn't Apply Fonts with Same Name #5253Context::add_font#5228