Fix panic due to non-total ordering in Area::compare_order()
#5569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5569-patch-2 |
emilk
approved these changes
Jan 2, 2025
twvd
pushed a commit
to twvd/snow-egui
that referenced
this pull request
Jul 20, 2025
…#5569) [Area::compare_order()](https://github.com/emilk/egui/blob/ee4ab08c8a208f4044a8c571326c9414e7a1c8a6/crates/egui/src/memory/mod.rs#L1174-L1183) is not a total ordering. If three layers A, B, and C have the same `order` field but only A and B are present in `order_map`, then `A==C` and `B==C` but `A!=C`. This can cause a panic in the stdlib sort function, and does in [my app](https://github.com/HactarCE/Hyperspeedcube/tree/v2.0) although it's very difficult to reproduce. * [x] I have self-reviewed this PR and run `./scripts/check.sh` * [x] I have followed the instructions in the PR template
twvd
added a commit
to twvd/snow
that referenced
this pull request
Jul 20, 2025
This happened sporadically when vigorously navigating the menu's and is caused by an issue in egui 0.30 (fixed in 0.31), triggered by a change in Rust 1.81: https://blog.rust-lang.org/2024/09/05/Rust-1.81.0/#new-sort-implementations See upstream PR: emilk/egui#5569 This commit bumps Snow's egui fork to a version with the fix cherry picked.
twvd
added a commit
to twvd/snow
that referenced
this pull request
Jul 20, 2025
This happened sporadically when vigorously navigating the menu's and is caused by an issue in egui 0.30 (fixed in 0.31), triggered by a change in Rust 1.81: https://blog.rust-lang.org/2024/09/05/Rust-1.81.0/#new-sort-implementations See upstream PR: emilk/egui#5569 This commit bumps Snow's egui fork to a version with the fix cherry picked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Area::compare_order() is not a total ordering. If three layers A, B, and C have the same
orderfield but only A and B are present inorder_map, thenA==CandB==CbutA!=C. This can cause a panic in the stdlib sort function, and does in my app although it's very difficult to reproduce../scripts/check.sh