Remove accesskit feature and always depend on accesskit
#7701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7701-emilkremove-accesskit-feature View snapshot changes at kitdiff |
783831a to
e17eb4a
Compare
e17eb4a to
f10949f
Compare
1 task
lucasmerlin
approved these changes
Nov 12, 2025
Collaborator
lucasmerlin
left a comment
There was a problem hiding this comment.
I guess the only bad thing about this is that it will further bloat the wasm bundle sizes (even tough accesskit doesn't even support wasm).
Owner
Author
|
It indeed adds almost 100kB, from 7 367 kB to 7 451 kB, but I think its worth it not to have all those feature flags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accesskitfeature inegui, and always depend on it #3137With this,
eguiwill always depend onaccesskit, removing a lot of#[cfg(feature = "accesskit")]throughout the code.