plugin: export TypedPluginGuard and TypedPluginHandle
#7780
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7780-apekrosplugin-mod View snapshot changes at kitdiff |
emilk
reviewed
Dec 16, 2025
Owner
emilk
left a comment
There was a problem hiding this comment.
Let's not put undocumented things into the top egui namespace.
Please add docstrings to these types, but then do pub mod plugin instead of re-exporting the types directly, to reduce the number of things the user can auto-complete to with egui::
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made this patch internally on our fork as we use
TypedPluginGuardandTypedPluginHandleinternally