Apply preferred font weight when loading variable fonts #7790
+124
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `FontData::weight()` method stored the preferred weight but it was never applied to the actual font rendering. This change uses the weight value to configure skrifa's Location for the 'wght' axis, enabling proper variable font weight control in text rendering.
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/7790-feature/font-weight-0.33.3 View snapshot changes at kitdiff |
pmnxis
added a commit
to pmnxis/chama-optics
that referenced
this pull request
Dec 18, 2025
When loading variable fonts in egui, the first available weight was selected instead of the font’s default weight, making it impossible to control the rendered weight. This change applies the preferred weight (or the font’s default value) to the `wght` axis, ensuring variable fonts are rendered with the intended weight. Related PR: emilk/egui#7790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when loading a variable font (e.g. via
egui::FontData::from_static),the font was rendered using the default (often the lightest) weight,
ignoring any preferred weight configuration.
This change applies the specified weight to skrifa's
Locationfor thewghtaxis,ensuring that variable fonts are rendered with the intended font weight.
Summary
Fixes variable font weight not being applied during rendering. The
FontData::weight()method now properly configures the font variation axis.Changes
location: Locationfield toFontFaceto store variation coordinateslocationparameter through to glyph rendering functionsLocationRefinDrawSettingsandHintingInstanceWeight Priority
preferred_weightfromFontData::weight()us_weight_classLocation::default()Related Issue
Todo