Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JasperBRiedel
Copy link
Contributor

@JasperBRiedel JasperBRiedel commented Dec 19, 2025

Progress on updating MSRV to 1.92 so that we can update to wgpu version 28.0.0 in #7789

I'm still working on getting all checks passing. Remaining items that I'm aware of: unresolved link errors in the doc comments for egui, unsafe block missing a safety comment in eframe.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Preview available at https://egui-pr-preview.github.io/pr/7793-update-msrv-1920
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

View snapshot changes at kitdiff

@JasperBRiedel
Copy link
Contributor Author

I'm currently stuck on the following rustdoc error:

error: unresolved link to `UiStackInfo::new(UiKind::GenericArea)`
   --> crates/egui/src/containers/area.rs:175:22
    |
175 |     /// Default to [`UiStackInfo::new(UiKind::GenericArea)`].
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the struct `UiStackInfo` has no field or associated item named `new(UiKind`
    |
    = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

It seems like specifying an argument like this isn't valid?

A possible solution could be something like /// Default to [`UiStackInfo`] with kind [`UiKind::GenericArea`].?

@emilk
Copy link
Owner

emilk commented Dec 19, 2025

Sounds like a reasonable fix to me!

Btw, I'm a bit surprised to see wgpu having MSRV set to a version that is only a week old. It's a bit annoying to force every downstream crate use use the very latest Rust version, but 🤷

emilk added a commit that referenced this pull request Dec 19, 2025
@emilk emilk added the egui label Dec 19, 2025
uses: actions/checkout@v4
- name: Machete Check
run: cargo machete
cargo-machete:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert unrelated formatting changes 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was unintentional. I must have run the yaml formatter by accident, and didn't check the diff again 🤦

JasperBRiedel added a commit to JasperBRiedel/egui that referenced this pull request Dec 20, 2025
@JasperBRiedel JasperBRiedel marked this pull request as ready for review December 20, 2025 01:43
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@emilk emilk merged commit 661d5f9 into emilk:main Dec 20, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants