-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update MSRV from 1.88 to 1.92 #7793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`clippy::unchecked_time_subtraction`
`clippy::needless_doctest_main`
`wasm32-unknown-unknown`
|
Preview available at https://egui-pr-preview.github.io/pr/7793-update-msrv-1920 View snapshot changes at kitdiff |
|
I'm currently stuck on the following rustdoc error: It seems like specifying an argument like this isn't valid? A possible solution could be something like |
|
Sounds like a reasonable fix to me! Btw, I'm a bit surprised to see wgpu having MSRV set to a version that is only a week old. It's a bit annoying to force every downstream crate use use the very latest Rust version, but 🤷 |
.github/workflows/cargo_machete.yml
Outdated
| uses: actions/checkout@v4 | ||
| - name: Machete Check | ||
| run: cargo machete | ||
| cargo-machete: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert unrelated formatting changes 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that was unintentional. I must have run the yaml formatter by accident, and didn't check the diff again 🤦
* Reduce the diff for emilk#7793
emilk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ❤️
Progress on updating MSRV to 1.92 so that we can update to wgpu version 28.0.0 in #7789
I'm still working on getting all checks passing. Remaining items that I'm aware of: unresolved link errors in the doc comments for egui, unsafe block missing a safety comment in eframe.