Improved plot interaction methods #892
Conversation
egui/src/widgets/plot/mod.rs
Outdated
| self.ctx | ||
| } | ||
|
|
||
| /// The plot bounds as they were in the last frame. |
There was a problem hiding this comment.
What is its value the first frame? Would it make more sense to return None the first frame?
There was a problem hiding this comment.
I guess the same comment applies to screen_from_plot and plot_from_screen - what is apropiate to return the first frame?
There was a problem hiding this comment.
We made sure that the bounds never become invalid. So if no items have been added to the plot and the bounds were not specified in the builder, they will at least be in the valid range [-1.0, 1.0]. The first transform may not be very accurate, but valid and I prefer this to making the user deal with an Option just because of one frame. But maybe you know an instance where this could go wrong?
There was a problem hiding this comment.
I think it makes sense not to have to hassle with Option. But we should document what it returns the first frame. For instance: does it matter if this is called before or after adding plot items?
There was a problem hiding this comment.
Good point, I added some documentation.
emilk
left a comment
There was a problem hiding this comment.
I would love to see the docs on plot_bounds improved a bit, but you can do so in a later PR if you like.
Great work!
egui/src/widgets/plot/mod.rs
Outdated
| last_screen_transform: Option<ScreenTransform>, | ||
| last_screen_transform: ScreenTransform, | ||
| response: Response, | ||
| ctx: &'ctx CtxRef, |
There was a problem hiding this comment.
CtxRef is just a wrapper around an Arc, so alternatively you can clone it so you don't have to worry about lifetimes
egui/src/widgets/plot/mod.rs
Outdated
| self.ctx | ||
| } | ||
|
|
||
| /// The plot bounds as they were in the last frame. |
There was a problem hiding this comment.
I think it makes sense not to have to hassle with Option. But we should document what it returns the first frame. For instance: does it matter if this is called before or after adding plot items?
Closes #891
Changes:
plot_ui.ctx()inside the plotshowclosure.PlotUimethods:ctx,plot_bounds,plot_hoveredandscreen_from_plot.plot_from_screenfunction.Plot::shownow returns anInnerResponseto be consistent with similar functions.@emilk I noticed that the plot demo instructions say "Pan by dragging, or scroll (+ shift = horizontal).". This does not work on my system though. Is this a bug or is the note outdated?