Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@misi89
Copy link
Contributor

@misi89 misi89 commented Oct 22, 2021

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Hungarian language support + translation add.

Issue Number

Example: #123

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Other information

@oceanlvr oceanlvr requested review from oceanlvr and ysfscream and removed request for oceanlvr October 22, 2021 15:10
@oceanlvr
Copy link
Contributor

Well done! Köszönöm 🇭🇺 🇭🇺 🇭🇺 !

@oceanlvr
Copy link
Contributor

@misi89 Hi, it seems that CI/CD failed. please check again. :)

Reference this PR, please.
https://github.com/emqx/MQTTX//commit/6604a6810c906f265211ff21a607fa9e2ddc7877

Thanks for your great job again.

@misi89
Copy link
Contributor Author

misi89 commented Oct 25, 2021

just fixed index.ts

@misi89 misi89 closed this Oct 25, 2021
@misi89 misi89 reopened this Oct 25, 2021
@ysfscream
Copy link
Member

@misi89 Thanks for making MQTT X more international 🇭🇺

@misi89
Copy link
Contributor Author

misi89 commented Oct 25, 2021

fixed it Thanks

@misi89 misi89 closed this Oct 25, 2021
@misi89 misi89 reopened this Oct 25, 2021
@ysfscream
Copy link
Member

ysfscream commented Oct 25, 2021

@misi89 Something looks wrong again 😢

Please take a careful look at the error log to ensure the code is working properly. There also seem to be some syntax and formatting errors. If possible, you may choose to modify this PR after it has run properly on your local machine.

Build error info: https://github.com/emqx/MQTTX/runs/3998569064?check_suite_focus=true

@ysfscream
Copy link
Member

OK, anyway! I will merge this PR and help you support this language.

@ysfscream ysfscream merged commit 4d2b85f into emqx:master Oct 28, 2021
@ysfscream
Copy link
Member

Hi! @misi89 We support now! The next version will support the Hungarian language, this is your contribution, thank you very much.

image

@misi89
Copy link
Contributor Author

misi89 commented Oct 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants