0930 deduplicate reconnect callbacks 0.5.9 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure the reconnect callbacks are evaluated in reversed order of how they were adeed
thalesmg
reviewed
Sep 30, 2024
only reverse the order when apply the callbacks
thalesmg
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes EEC-1097
The issue, is the reconnect callbacks are evaluated in the reversed order when they were added.
But the infinite growth of the list is a ticking bomb.
So this PR also made an attempt to make it possible to deduplicate.
The fix is quite hacky in oder to support hot-upgrade.
related: emqx/epgsql#11