fix(tconf): type in hocon_schema:override/2 is optional
#309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a dialyzer annoyance when overriding fields other than `type`.
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
Jun 25, 2025
emqx/hocon#309 Fixes `hocon_schema:override/2` typespec so dialyzer doesn't yell when you don't want to override the field type.
keynslug
approved these changes
Jun 26, 2025
| -type field_schema_fun() :: fun((_) -> _). | ||
| -type field_schema_map() :: | ||
| #{ | ||
| type := type(), |
There was a problem hiding this comment.
Given how loosely defined other types are, I think just changing to type => type() here could be a good practical solution.
There was a problem hiding this comment.
For defining a schema, the type is really required, so I think it's good to make it explicit in the type.
Though, if the macro hack had not worked, I probably would have gone that way too. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a dialyzer annoyance when overriding fields other than
type.