Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Catch exception if close() in exception manager, throw another except… #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Catch exception if close() in exception manager, throw another except… #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion httpcore/_async/connection_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ async def __aiter__(self) -> typing.AsyncIterator[bytes]:
async for part in self._stream:
yield part
except BaseException as exc:
await self.aclose()
try:
await self.aclose()
except BaseException:
pass
raise exc from None

async def aclose(self) -> None:
Expand Down
5 changes: 4 additions & 1 deletion httpcore/_sync/connection_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ def __iter__(self) -> typing.Iterator[bytes]:
for part in self._stream:
yield part
except BaseException as exc:
self.close()
try:
self.close()
except BaseException:
pass
raise exc from None

def close(self) -> None:
Expand Down
Loading