Fix absolute paths resolving in Node.resolvePath #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d2f997 to
4e7f76a
Compare
|
А зачем это нужно? |
|
This is for loading any files via E.g.: addTechs([
[require('enb/techs/file-provider'), { target: require.resolve('bem-xjst') }],
[fileMerge, { sources: require.resolve('bem-xjst') }]
])Is it works like that? |
4e7f76a to
efe7b34
Compare
efe7b34 to
06c2604
Compare
blond
added a commit
that referenced
this pull request
Feb 20, 2016
Fix absolute paths resolving in Node.resolvePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change needed to allow
file-providertech work with absolute paths.I'm not sure should it be like this or via
path.resolve. Personally I prefer the last one.