What's the point to use CommonJS format in Cache files? #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Нужно поменять имя расширение с https://github.com/enb-make/enb/blob/master/lib/make.js#L119 |
|
Может сделаем |
|
Можно. В этом таске? |
Я не против =) |
|
@blond Где мы load используем? Где можем заменить load на loadAsync? |
|
https://github.com/enb-make/enb/blob/3b2c0ab8b19201c1abd862463cc817a84573721d/lib/make.js#L195-L218 Если не ломать API, тогда надо делать ещё и |
af8619c to
86b4b43
Compare
86b4b43 to
2938fdd
Compare
blond
added a commit
that referenced
this pull request
Feb 20, 2016
What's the point to use CommonJS format in Cache files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes load/save logic in CacheStorage.
Now it uses JSON.parse+fs.readFileSync instead of require+clearRequire.
/cc @blond