Support node 4 #438
Merged
Support node 4 #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/lib/make/init.js
Outdated
| }); | ||
|
|
||
| expect(require.cache[modulePath]).to.be.not.equal('foo'); | ||
| expect(clearRequire.calledWith('/path/to/project/.enb/make.js')).to.be.true; |
There was a problem hiding this comment.
expect(clearRequire).to.be.calledWith() ?
586d355 to
7d0dbf6
Compare
Closed
3933b8b to
c341519
Compare
| 'make.js': '' | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
А mockFs({ path.normalize('full/path/to/file.js'): '' }); не работает?
There was a problem hiding this comment.
Исправил.
А тут зачем path.normalize?
There was a problem hiding this comment.
Хз. если под вендой окей, то мне ок)
d1dc0af to
da2c498
Compare
test/lib/make/init.js
Outdated
| projectConfig.setLanguages(['ru']); | ||
| }); | ||
| mockRequire(path.normalize('/path/to/project/.bem/make.js'), function (projectConfig) { | ||
| projectConfig.setLanguages(['ru']); |
da2c498 to
95cd216
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.