-
Couldn't load subscription status.
- Fork 54
Fix profiler times #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix profiler times #500
Conversation
|
/cc @emelyanovtv @rndD |
510c8d5 to
564db21
Compare
| * BuildProfiler | ||
| * ====== | ||
| */ | ||
| var inherit = require('inherit'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а это не линтится?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в этом проекте нет
|
|
|
❤️ tests |
lib/build-profiler.js
Outdated
| } else if (depEndTime < targetStartTime) { | ||
| selfTime = targetEndTime - targetStartTime; | ||
| } | ||
| timeline = selfRanges.map(function (range) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вот это просто конвертация формата, вполне выделяем в отдельную функцию.
Если захотеть, то можно рисовать таймлайн сборки. Примерно как |
Before this changes the `buildTime` field show sum of targets self times instead of real time.
564db21 to
eaf84f4
Compare
|
🆙 |
No description provided.