Add Miri checks #1 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements Miri (Rust's memory safety checker) compatibility for the movable-ref crate. The changes focus on making self-reference operations safe under Miri's strict memory model while maintaining backwards compatibility.
Key changes include:
- Added new base-pointer-based access methods that work with Miri's provenance tracking
- Updated function signatures to require
&mut selfwhere pointer provenance matters - Introduced a new
SelfRefCellabstraction and macro helpers for ergonomic usage
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pointer/self_ref.rs | Core implementation with Miri-compatible pointer operations and new base-pointer methods |
| src/tests.rs | Updated tests to use new API patterns and removed problematic assertions |
| src/macros.rs | New macro for generating self-reference accessor methods |
| src/combinators/self_ref_cell.rs | New high-level abstraction wrapping SelfRef for safer usage |
| src/lib.rs | Added feature flags and module exports for new functionality |
| examples/ | Updated examples to demonstrate new SelfRefCell API |
| .github/workflows/ci.yml | Added Miri testing to CI pipeline |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1