New: Add scan_dependencies and scan_secrets #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| with: | ||
| namespace: "example" | ||
| scan_dependencies: "true" | ||
| scan_secrets: "true" |
Contributor
There was a problem hiding this comment.
Do we want to enable this by default? Prior to this PR, the github action would not enable secret scanning, right?
Contributor
There was a problem hiding this comment.
I think its fair to do secrets by default as long as we aren't doing the full history scan by default.
Contributor
Author
There was a problem hiding this comment.
Right now only dependencies (git,analytics) are enabled by default
Contributor
There was a problem hiding this comment.
Stick with consistency
Contributor
|
Do we need pre_commit_checks here? Given that the GitHub action is going to scan post commit always is there a use case for this? @ewokcami |
IAmATeaPot418
approved these changes
Oct 13, 2023
IAmATeaPot418
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Rename CI run parameters * Prettier * Even prettier * The prettiest * More pretty * Let's see if this helps * Resolve conflicts * Remove extra line added by prettier * Escape quotes in action description * Cleanup config parameter descriptions and fix defaults * Better ci-run error handling * New: Add scan_dependencies and scan_secrets (#30) * Cleanup action.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
scan_dependenciesscan_secretsscan_git_logs+ Update README accordingly