Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bumping node version to node20 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cp-endor merged 3 commits into from
May 14, 2024
Merged

Bumping node version to node20 #56

cp-endor merged 3 commits into from
May 14, 2024

Conversation

@cp-endor
Copy link
Contributor

@cp-endor cp-endor commented May 11, 2024 •
edited
Loading

@cp-endor cp-endor requested review from dstiliadis and peter-cg May 11, 2024 09:37
@peter-cg peter-cg requested a review from hghmn May 13, 2024 01:04
@hghmn
Copy link
Contributor

hghmn commented May 13, 2024 •
edited
Loading

Could this also bump the recommended node versions to be consistent with node version >=20 in:

github-action/package.json

Lines 47 to 48 in a8ac7b4

"engines": {
"node": ">=16.13.2",

github-action/CONTRIBUTING.md

Lines 22 to 23 in a8ac7b4

- [node](https://nodejs.org/en): JavaScript runtime environment used for the GitHub action development
- Recommended version ">=16.13.2"

hghmn
hghmn approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@hghmn hghmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cp-endor!

@cp-endor cp-endor merged commit 05d00dc into main May 14, 2024
@cp-endor cp-endor deleted the bump-node-version branch May 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hghmn hghmn hghmn approved these changes

@peter-cg peter-cg Awaiting requested review from peter-cg

@dstiliadis dstiliadis Awaiting requested review from dstiliadis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cp-endor @hghmn