Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rsylim804
Copy link
Contributor

@rsylim804 rsylim804 commented Jan 8, 2025

Add support for scan_ai_models.
The docs will need to be updated to cover this new capability @madhurikaranth24.

@rsylim804 rsylim804 marked this pull request as ready for review January 8, 2025 22:30
@dkourkouzelis
Copy link
Contributor

Looks good! Does it work? 😄

@rsylim804
Copy link
Contributor Author

@dkourkouzelis thanks to you! is there a way to test this locally? I thought it would have to go into staging first?

@dkourkouzelis
Copy link
Contributor

Look at this PR.

You could create a PR for the monorepo that adds a new job in linters.yml with the proper parameters (instead of sast). Then, as part of this line:

uses: endorlabs/github-action@a8ad74e765949855c4508590cf5e84258f9524d1

replace the SHA (a8ad74...) with the git SHA of your PR here. So

uses: endorlabs/github-action@148300e004442fe850f73225db898931f07560a4

you don't have to merge that PR but you will know if the scan will work.

Altetnatively, you could create an "ai-models-demo" repo similar to app-java-demo that has some models and is using the GitHub action to scan. Eg, for SAST.

@rsylim804
Copy link
Contributor Author

@dkourkouzelis seems to run smoothly here is the PR here https://github.com/endorlabs/monorepo/actions/runs/12681804370/job/35346164588?pr=18370#step:8:80

There's no HF models found being used in our monorepo (which makes sense) but I can see the ai scan being elicited ("starting ai-models scanner") successfully so looks like it's working here!

@dkourkouzelis
Copy link
Contributor

@dkourkouzelis seems to run smoothly here is the PR here endorlabs/monorepo/actions/runs/12681804370/job/35346164588?pr=18370#step:8:80

There's no HF models found being used in our monorepo (which makes sense) but I can see the ai scan being elicited ("starting ai-models scanner") successfully so looks like it's working here!

Fantastic! 😄

@rsylim804 rsylim804 merged commit 2d4f78f into main Jan 9, 2025
3 checks passed
@rsylim804 rsylim804 deleted the scan-ai-models branch January 9, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants