feat: added organization based knowledge #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some important updates in the PR: - New organization tab accessible for admins. - Migrations for older versions. - All spaces get access to organization made knowledge. - Organization space only has knowledge unlocked. - Collections and websites are supported with organization. Todo: Implement support for organization based integration knowledge. Today the integration knowledge will cause issues if used on a organization level, needs support before used.
axelander
reviewed
Aug 26, 2025
backend/poetry.lock
Outdated
There was a problem hiding this comment.
Seems like you have regenerated the lock-file with an older version of poetry. Did you use poetry via the devcontainer or outside? (https://github.com/eneo-ai/eneo/blob/develop/.devcontainer/post-create.sh#L13). Since it renders such a big diff without any actual changes maybe reset the file and rerun poetry install with a later version of poetry (2.1.3).
There was a problem hiding this comment.
Yes exactly, I'm running via devcontainer but had a few issues setting everything up at first. Something must have gone wrong there. But I'll fix this and resubmit tomorrow. Thanks
|
Can you look into resolving the branch conflicts and the poetry.lock updates? Other than that I think it looks good 👍 |
- Backend tests for regarding spaces has been fixed.
- This fix re enables settings for organization to make changes for embedding models. - Collections needs embedding to be enabled.
…tion-based-knowledge
Resolved conflicts in: - Frontend: +layout.svelte, WebsiteTable.svelte, +page.svelte, en.json, sv.json - Backend: space_repo.py, website_models.py Combined organization-based knowledge features with latest develop changes including HTTP auth support, bulk website operations, and OIDC authentication. Fixed missing imports in auth_dependencies.py.
**Test Files Created:** - test_organization_space.py (8 tests) - test_knowledge_distribution.py (8 tests) - test_knowledge_retrieval.py (6 tests) - test_knowledge_permissions.py (1 passing, 4 skipped awaiting SpaceActor methods) - test_organization_knowledge_e2e.py (3 tests) **Fixtures Created:** - organization_knowledge.py with factories for: - tenant_factory: Creates test tenants with quota_limit - user_factory: Creates test users - user_integration_factory: Creates proper integration chains (Integration → TenantIntegration → UserIntegration) - embedding_model_factory: Creates embedding models with required fields **Fixes Applied:** 1. Added quota_limit default to tenant_factory fixture 2. Fixed EmbeddingModels fixture to use actual required fields (open_source, family, stability, hosting) 3. Updated user_integration_factory to properly create Integration → TenantIntegration chain 4. Added created_at/updated_at columns to IntegrationKnowledgesSpaces migration 5. Fixed Space domain entity instantiation with helper function _space_from_db() 6. Corrected SpaceRoleValue import and usage throughout tests 7. Fixed is_organization() method calls (added parentheses)
664a1ce to
b85f5d0
Compare
b938647 to
c2bf524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some important updates in the PR: