fix: prevent UpdateNewValues from overwriting fields with defaults #4458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3675
UpdateNewValues()was incorrectly overwriting existing database values with default values when those fields were not explicitly set in the upsert operation.The issue occurred because
defaults()runs before SQL generation, adding default values to the mutation. The callback then saw these fields as "set" and included them in theUPDATEclause, overwriting existing database values.Solution:
defaults()runs for fields withDefault()ResolveWithNewValues()path for entities without standalone defaultsDefault()(excludingImmutableandUpdateDefaultfields, which work correctly)