Don't leak session vars back to connection pool on tx commit/rollback (cross-dialect alternative) #4469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #4468 that works across dialects.
From the original PR:
This PR make sure that sql vars are reset every single statement inside a transaction and works across database types (doesn't rely on PostgreSQL-specific
SET LOCAL). This is also more correct if users are setting different sqlvars across different statement inside their transaction (edge case).The negative aspect of this PR is that we will issue
RESETstatements after every statement in a query (but only if sqlvars are actually used)