initial address for #1310 - allow the user to check if an error is a … #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Mar 9, 2021
Member
a8m
left a comment
There was a problem hiding this comment.
Looks good @rotemtam. Thanks for adding this. I've added minor suggestions.
Please use the following commit format when it's possible, it makes my life easier when I'm releasing a new version.
<package>: <message>
For example
dialect/sql/sqlgraph: add constraint error checks
Fixed #ISSUE-NUMBER
dialect/sql/sqlgraph/errors.go
Outdated
Comment on lines
19
to
21
| "mysql": "Error 1062", | ||
| "postgres": "violates unique constraint", | ||
| "sqlite": "UNIQUE constraint failed", |
Member
There was a problem hiding this comment.
Use dialect.MySQL, dialect.PostgreSQL, etc instead of these strings. Why do we need this, and not just [3]string{...}?
Contributor
Author
There was a problem hiding this comment.
we don't, i'm removing
dialect/sql/sqlgraph/errors.go
Outdated
| } | ||
|
|
||
| // IsUniquenessConstraintError returns true if the error resulted from a DB uniqueness constraint error | ||
| func IsUniquenessConstraintError(err error) bool { |
Member
There was a problem hiding this comment.
Suggested change
| func IsUniquenessConstraintError(err error) bool { | |
| func IsUniqueConstraintError(err error) bool { |
Uniqueness is too long. Let's change it to Unique.
dialect/sql/sqlgraph/errors.go
Outdated
Comment on lines
11
to
16
| // IsConstraintError returns true if the error resulted from a DB constraint error | ||
| func IsConstraintError(err error) bool { | ||
| return IsUniquenessConstraintError(err) || IsForeignKeyConstraintError(err) | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| // IsConstraintError returns true if the error resulted from a DB constraint error | |
| func IsConstraintError(err error) bool { | |
| return IsUniquenessConstraintError(err) || IsForeignKeyConstraintError(err) | |
| } | |
| // IsConstraintError returns true if the error resulted from a DB constraint error. | |
| func IsConstraintError(err error) bool { | |
| var e *ConstraintError | |
| return errors.As(err, &e) || IsUniquenessConstraintError(err) || IsForeignKeyConstraintError(err) | |
| } |
It does make sense to return true is the error is type ConstraintError as well. Also, please add more details regarding the possible constraint errors.
dialect/sql/sqlgraph/errors.go
Outdated
| return IsUniquenessConstraintError(err) || IsForeignKeyConstraintError(err) | ||
| } | ||
|
|
||
| // IsUniquenessConstraintError returns true if the error resulted from a DB uniqueness constraint error |
Member
There was a problem hiding this comment.
Suggested change
| // IsUniquenessConstraintError returns true if the error resulted from a DB uniqueness constraint error | |
| // IsUniqueConstraintError reports if the error resulted from a DB uniqueness constraint violation. e.g. duplicate value in unique index. |
dialect/sql/sqlgraph/errors.go
Outdated
| return false | ||
| } | ||
|
|
||
| // IsForeignKeyConstraintError returns true if the error resulted from a DB FK constraint error |
Member
There was a problem hiding this comment.
Suggested change
| // IsForeignKeyConstraintError returns true if the error resulted from a DB FK constraint error | |
| // IsForeignKeyConstraintError reports if the error resulted from a DB FK constraint violation. e.g. parent row does not exist. |
Initial work on ent#1310
ad85e8c to
282d7bb
Compare
a8m
reviewed
Mar 9, 2021
| require.False(t, pets[2].QueryOwner().ExistX(ctx)) | ||
| } | ||
|
|
||
| func ConstraintChecks(t *testing.T, client *ent.Client) { |
Member
There was a problem hiding this comment.
Let's remove them after it's added to templates (it should be in sqlgraph).
a8m
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…constraint error and if it is related to uniqueness or FK