entc/integration: fix gremlin server version #1808
Conversation
| FROM tinkerpop/gremlin-server:3.4.11 | ||
|
|
||
| # Copy overriden server configuration. | ||
| COPY gremlin-server.yaml tinkergraph-empty.properties /opt/gremlin-server/conf/ |
There was a problem hiding this comment.
Hey @seiichi1101 and thanks for contributing this fix.
The CI is failing, can you please debug why? I think you need to use this configuration file in the CI as well.
There was a problem hiding this comment.
I think we should pin this version as Seiichi did. And rebuild image entgo/gremlin-server for CI.
There was a problem hiding this comment.
OK. I will debug why ci is failing.
There was a problem hiding this comment.
The CI is failing, can you please debug why?
This was because the configuration file is not attached to tinkerpop/gremlin-server:3.4.11 in ci.
So, I modified the gremlin-server in ci to use the local configuration file gremlin-server.yaml and tinkergraph-empty.properties.
In this PR, I changed not to use entgo/gremlin-server anymore because it looks unmaintained.
There was a problem hiding this comment.
The owner of entgo/gremlin-server is the Ent team.
cc: @alexsn
There was a problem hiding this comment.
Why not build a entgo/gremlin-server:3.4.11 at the beginning and use it the rest of the test?
There was a problem hiding this comment.
Hi, @yonidavidson
Why not build a entgo/gremlin-server:3.4.11 at the beginning and use it the rest of the test?
Could you elaborate on that?
|
Hi @seiichi1101 , to make this work the only change needed is in the dockerfile FROM tinkerpop/gremlin-server:3.4.11if you want to make sure that cache isn't using the old built version in ci/localhost we can TAG the file in the docker-compose as well: gremlin:
platform: linux/amd64
image: entgo/gremlin-server:3.4.11
build: gremlin-server
restart: on-failure
ports:
- 8182:8182 |
|
Hi, @yonidavidson It is fine to add The problem is that when CI is run, The other way is to update Docker Hub before running CI or within CI, but I don't have permission. |
|
|
||
| gremlin: | ||
| platform: linux/amd64 | ||
| image: entgo/gremlin-server |
There was a problem hiding this comment.
why not give it the explicit name? entgo/gremlin-server:3.4.11
| - 8182:8182 | ||
|
|
||
| wait: | ||
| image: willwill/wait-for-it:latest |
There was a problem hiding this comment.
This is for CI.
This is necessary for waiting until entgo/gremlin-server image is run.
| FROM tinkerpop/gremlin-server:3.4.11 | ||
|
|
||
| # Copy overriden server configuration. | ||
| COPY gremlin-server.yaml tinkergraph-empty.properties /opt/gremlin-server/conf/ |
There was a problem hiding this comment.
Why not build a entgo/gremlin-server:3.4.11 at the beginning and use it the rest of the test?
|
@seiichi1101 , please have a look at #1894 I made the docker-compose use the tinkerpop image directly. |
|
Check #1807 , I updated the dockerhub image so CI will just work, all is left is to update the integration test dockerfile. |
7172354 to
180f27f
Compare
|
Thanks, everyone. |
|
@all-contributors please add @seiichi1101 for code. |
|
I've put up a pull request to add @seiichi1101! 🎉 |
|
Thanks @seiichi1101 for your contribution, and thanks @yonidavidson and @giautm for the support and the review 🙏 ❤️ |
Fix for #1807.