Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dialect/sql: report explicit error when trying to SELECT .. FOR UPDAT… #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a8m merged 2 commits into from
Aug 17, 2021
Merged

dialect/sql: report explicit error when trying to SELECT .. FOR UPDAT… #1847

a8m merged 2 commits into from
Aug 17, 2021

Conversation

@rotemtam
Copy link
Contributor

@rotemtam rotemtam commented Aug 17, 2021 •
edited
Loading

…E with sqlite

Related to the first issue mentioned in #1830

@rotemtam rotemtam requested a review from a8m August 17, 2021 09:47
a8m
a8m approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rotemtam. Thanks for fixing this ❤️

@a8m a8m merged commit f326c7d into master Aug 17, 2021
@a8m a8m deleted the feat/sqlite-for-update-error branch August 17, 2021 09:54
@a8m a8m mentioned this pull request Aug 17, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a8m a8m a8m approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rotemtam @a8m