entc/gen: allow distinct in sqlQuery to enable distinct work in Select() #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://dashboard.github.orijtech.com?back=0&pr=1959&remote=true&repo=EndlessIdea%2Fent to see benchmark details. |
Member
|
Thanks for your contribution @EndlessIdea 🙏 This looks good. I'll wait for the CI to pass and review this. |
a8m
added a commit
that referenced
this pull request
Sep 21, 2021
Unique Field Selection - Merge #1959
Member
|
Thanks for your contribution @EndlessIdea and @Lining-Grab. @all-contributors please add @EndlessIdea and @Lining-Grab for code. |
Contributor
|
I've put up a pull request to add @EndlessIdea! 🎉 |
Contributor
Author
|
Thank you @a8m ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We find using xxx.Query().Unique(true).Select("field1").Strings(ctx) doesn't return the expected distinct values we want.
For example, there are two records:
The value of xxx.Query().Unique(true).Select("city").Strings(ctx) is [Singapore, Singapore], but [Singapore] is the expected return value.