Add Sensitive() option to bytesBuilder #1982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a use case where I want to store bytes but I want to use the sensitive option.
a8m
approved these changes
Sep 25, 2021
Member
a8m
left a comment
There was a problem hiding this comment.
Thanks for adding this @evanlurvey.
Would you mind adding an example field to our integration tests and run the codegen? See: https://github.com/ent/ent/blob/master/entc/integration/ent/schema/fieldtype.go#L198
Contributor
Author
|
@a8m I think I did what you asked. Not sure if I did the generate correctly, I ran |
Member
|
Thanks for your contribution @evanlurvey 🙏 @all-contributors please add @evanlurvey for code |
Contributor
|
I've put up a pull request to add @evanlurvey! 🎉 |
yonidavidson
pushed a commit
to yonidavidson/ent
that referenced
this pull request
Nov 24, 2021
* Add Sensitive() option to bytesBuilder I have a use case where I want to store bytes but I want to use the sensitive option. * Added new field test and ran generation Co-authored-by: Evan Lurvey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I want to store bytes but I want to use the sensitive option.