entc/gen: ignore immutable fields on Upsert<T>.UpdateNewValues #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8232c87 to
78b88d2
Compare
2 tasks
tankbusta
reviewed
Oct 6, 2021
Collaborator
|
I'll have a look tomorrow. |
masseelch
approved these changes
Oct 7, 2021
Collaborator
masseelch
left a comment
There was a problem hiding this comment.
LGTM
As a reminder: docs are missing ;-)
78b88d2 to
895187a
Compare
Also, for some reason, the TimeMixin.UpdateTime was an immutable field, but this was incorrent, because the codegen just skip generating update setters to it. Removing the Immutable modifier allows users to set this field explicitly.
895187a to
82c7811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, for some reason, the
TimeMixin.UpdateTimewas an immutable field, but this was incorrect because the codegen just skipped generating update setters for it, and it was still get updated by theUpdateDefaultmodifier. Removing the Immutable modifier allows users to set this field explicitly.Fixed #2000