fix: update only/onlyID comments #2274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this patch updates the Only/OnlyID methods in the builder template from:
> // Returns a *NotSingularError when exactly one {{ $.Name }} entity is not found.
to
> // Returns a *NotSingularError when more than exactly one {{ $.Name }} ID is found.
in an effort to be more explicit in the explanation of the behavior of the methods.
rotemtam
reviewed
Jan 18, 2022
hilakashai
reviewed
Jan 18, 2022
Contributor
Author
|
i was able to run |
Member
|
Thanks for your contribution @iamnande 🙏 ❤️ @all-contributors please add @iamnande for code |
Contributor
|
I've put up a pull request to add @iamnande! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch updates the Only/OnlyID methods in the builder template from:
in an effort to be more explicit in the explanation of the behavior of the methods.
I caught myself reading the difference between the lines more than a few times just to make sure I truly understood the behavior. Maybe others agree?