Allow ID to use field.Other with custom types #2309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
approved these changes
Feb 9, 2022
Member
a8m
left a comment
There was a problem hiding this comment.
Amazing @crossworth ❤️
Thanks for the contribution!
Co-authored-by: Ariel Mashraki <[email protected]>
Member
|
@all-contributors please add @crossworth for code |
Contributor
|
I've put up a pull request to add @crossworth! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using field.Other the generated code would cause problems on two instances:
https://github.com/crossworth/entissue2290/blob/042ee692b298775220878f08082e6592575eef58/ent/user_create.go#L231
https://github.com/crossworth/entissue2290/blob/042ee692b298775220878f08082e6592575eef58/ent/user.go#L56
Line 56:
conversion from int64 to ID (string) yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)I'm not sure if this is the best way to solve the problem, but I think we can assume that when the user use a
field.Otherit would not be~int64.This WILL NOT fix the problem when using
GoType. The same problem happens, but I don't know how to solve, maybe a better approach would be to check the type.Partial fix for: #2290