Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@masseelch
Copy link
Collaborator

No description provided.

Copy link
Contributor

@hilakashai hilakashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@rotemtam rotemtam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas on improving the introduction

author: MasseElch
authorURL: "https://github.com/masseelch"
authorImageURL: "https://avatars.githubusercontent.com/u/12862103?v=4"
image: tbd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need an image 😀

@masseelch masseelch requested a review from rotemtam March 14, 2022 07:13
Comment on lines 28 to 33
> Liquibase is an open-source database schema change management solution which enables you to manage revisions of your
> database changes easily. Liquibase makes it easy for anyone involved in the application release process to:
>
> - Eliminate errors and delays when releasing databases.
> - Deploy and roll back changes for specific versions without needing to know what has already been deployed.
> - Deploy database and application changes together so they always stay in sync.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some segue into the self-description of another project. Also, I would take a definition of versioned migrations or some description of the mechanism instead of the general "marketing copy" of the project. The point is to use others' words to explain the concept of versioned migrations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't really have a description 😢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rotemtam I added a description of it in my own words now. I cannot find a good explanation on the mentioned tools' docs.

@masseelch masseelch requested a review from rotemtam March 14, 2022 08:16
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I love it.

Copy link
Contributor

@hedwigz hedwigz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 👏 👏 👏

@masseelch masseelch merged commit 41db628 into master Mar 14, 2022
@masseelch masseelch deleted the versioned-migrations/blog branch March 14, 2022 13:47
zeevmoney added a commit to zeevmoney/ent that referenced this pull request Mar 15, 2022
* master:
  doc/website/blog: versioned migrations (ent#2387)
  build(deps): bump github.com/spf13/cobra from 1.3.0 to 1.4.0 (ent#2386)
  go: upgrade atlas for tidb support (ent#2394)
  dialect/sql/schema: add method to create a named versioned migration … (ent#2385)
  docs: add maorlipchuk as a contributor for code (ent#2381)
  entc/gen: set Ref and Inverse for edge contains both From and To
  schema/field: expose RType.Implements method (ent#2379)
  docs: add imhuytq as a contributor for code (ent#2378)
  dialect/sql/schema: add name to versioned migration files (ent#2375)
  all: update atlasgo.io to latest (ent#2376)
  dialect/sql/schema: fix bug in atlas integration when working WithDropIndex/WithDropColumn (ent#2374)
  build(deps): bump actions/checkout from 2.4.0 to 3 (ent#2372)
  build(deps): bump actions/setup-node from 2.5.1 to 3 (ent#2365)
gitlawr pushed a commit to gitlawr/ent that referenced this pull request Apr 13, 2022
* doc/md: clarify when feature flag is needed for versioned migrations

* doc/website/blog: introduction

* doc/md: more blog post

* Apply suggestions from code review

Co-authored-by: Hila Kashai <[email protected]>

* doc/website/blog: move explanation about versioned migration purpose up

* doc/website/blog: apply CR

* doc/website/blog: reword desription of versioned migrations

* doc/website/blog: typos

* doc/website/blog: last minute changes pre publish

Co-authored-by: Hila Kashai <[email protected]>
gitlawr pushed a commit to seal-io/ent that referenced this pull request Apr 13, 2022
* doc/md: clarify when feature flag is needed for versioned migrations

* doc/website/blog: introduction

* doc/md: more blog post

* Apply suggestions from code review

Co-authored-by: Hila Kashai <[email protected]>

* doc/website/blog: move explanation about versioned migration purpose up

* doc/website/blog: apply CR

* doc/website/blog: reword desription of versioned migrations

* doc/website/blog: typos

* doc/website/blog: last minute changes pre publish

Co-authored-by: Hila Kashai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants