dialect/sql: without foreign keys option for atlas #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
a8m
reviewed
Mar 16, 2022
a8m
reviewed
Mar 16, 2022
a8m
reviewed
Mar 16, 2022
a8m
reviewed
Mar 16, 2022
a8m
reviewed
Mar 16, 2022
a8m
reviewed
Mar 16, 2022
Co-authored-by: Ariel Mashraki <[email protected]>
a8m
approved these changes
Mar 16, 2022
Member
a8m
left a comment
There was a problem hiding this comment.
Thanks, @zeevmoney for the contribution!
gitlawr
pushed a commit
to gitlawr/ent
that referenced
this pull request
Apr 13, 2022
* dialect/sql: without foreign key option for atlas * handle fks in modifytables * add tests * tests * Update dialect/sql/schema/atlas.go Co-authored-by: Ariel Mashraki <[email protected]> * ct and tests Co-authored-by: Ariel Mashraki <[email protected]>
gitlawr
pushed a commit
to seal-io/ent
that referenced
this pull request
Apr 13, 2022
* dialect/sql: without foreign key option for atlas * handle fks in modifytables * add tests * tests * Update dialect/sql/schema/atlas.go Co-authored-by: Ariel Mashraki <[email protected]> * ct and tests Co-authored-by: Ariel Mashraki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the support for disabling FK when running with Atlas migrations
As I see I will need to add mocks for Atlas SQL calls if I want to add tests. I can do it if needed, or maybe there is another way to add the tests?