Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@stoikheia
Copy link
Contributor

There is several tests using go-sqlite3 driver in this project.
It had to opt-in for using JSON functions.
Update go-sqlite3 driver, and we can run tests without -tags=json1.

I updated modules and modified the documentation and ci.yml.

mattn: "Released go-sqlite3 v1.14.13 json tag is now the default."
https://twitter.com/mattn_jp/status/1524936967720665088

For more detail is following page.
mattn/go-sqlite3#1019

@stoikheia
Copy link
Contributor Author

I fixed a CI failure.

This CI tests current master branch in a part of step of 'migration'.

- name: Checkout origin/master
run: git checkout origin/master
- name: Run integration on origin/master
working-directory: entc/integration
run: go test -race -count=2 -tags='json1' ./...

I don't feel that I need this part of step.

To remove a remaining -tags=json1, I have to follow up after merge.

@a8m
Copy link
Member

a8m commented May 26, 2022

Thanks for the contribution @stoikheia 🙏

@a8m a8m merged commit f1c396a into ent:master May 26, 2022
@stoikheia
Copy link
Contributor Author

remaining unnecessary build flag -tags=json1 has been deleted.
#2672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants