Thanks to visit codestin.com
Credit goes to github.com

Skip to content

dialect/sql/schema: file based type store #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masseelch merged 6 commits into from
Jun 15, 2022
Merged

dialect/sql/schema: file based type store #2644

masseelch merged 6 commits into from
Jun 15, 2022

Conversation

@masseelch
Copy link
Collaborator

@masseelch masseelch commented Jun 13, 2022 •
edited
Loading

This PR adds support for a file based type storage when using versioned migrations. The file called .ent_types is written to the migration directory alongside the migration files and will be kept in sync for every migration file generation run.

In order to not break existing code, where the type storage might differ for different deployment, global unique ID mut be enabled by using a new option. This will also be raised as an error to the user when attempting to use versioned migrations and global unique ID.

Documentation will be added to this PR once feedback on the code is gathered.

Fixes #2587

I have discussed with Ariel already, that we will move the configuration for allocated pk ranges to the schema level. We haven't yet figured out, how to do this best, but it will come.

@masseelch masseelch requested review from a8m and rotemtam June 13, 2022 10:44
a8m
a8m approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic 💯

@olagziel
Copy link

olagziel commented Jun 14, 2022

Hey, I'm getting validating migration directory: checksum mismatch when trying to create a new migration (.Diff(..)) because it seems that the .ent_types file changed but the checksum isn't updated.

@masseelch
Copy link
Collaborator Author

masseelch commented Jun 14, 2022

Hey, I'm getting validating migration directory: checksum mismatch when trying to create a new migration (.Diff(..)) because it seems that the .ent_types file changed but the checksum isn't updated.

Good catch. I will both add a test and a fix for that :-)

@masseelch
Copy link
Collaborator Author

masseelch commented Jun 14, 2022 •
edited
Loading

@lagzi I changed added a commit, that should fix your problem. If it doesn't please ping me on Discord so I can help you resolve it 😊

@masseelch
dialect/sql/schema: file based type store
3e8ea0a 
This PR adds support for a file based type storage when using versioned migrations. The file called `.ent_types` is written to the migration directory alongside the migration files and will be kept in sync for every migration file generation run.

In order to not break existing code, where the type storage might differ for different deployment, global unique ID mut be enabled by using a new option. This will also be raised as an error to the user when attempting to use versioned migrations and global unique ID.

Documentation will be added to this PR once feedback on the code is gathered.
@masseelch masseelch force-pushed the versioned/global-unique-id branch from 8eeb23c to 3e8ea0a Compare June 14, 2022 15:23
a8m
a8m reviewed Jun 14, 2022
View reviewed changes
a8m
a8m reviewed Jun 14, 2022
View reviewed changes
a8m
a8m reviewed Jun 14, 2022
View reviewed changes
a8m
a8m reviewed Jun 14, 2022
View reviewed changes
@a8m
Copy link
Member

a8m commented Jun 14, 2022

Looks good 🚀

Please, fix the broken tests and I'll approve.

@masseelch masseelch force-pushed the versioned/global-unique-id branch from dda6d53 to d93b55d Compare June 15, 2022 06:42
@masseelch
Copy link
Collaborator Author

masseelch commented Jun 15, 2022 •
edited
Loading

Currently this PR is blocked on a checksum problem: .ent_types is added to the checksum as well and this has to be resolved on Atlas.

cc @a8m

@masseelch masseelch force-pushed the versioned/global-unique-id branch 2 times, most recently from 1e93cfe to 61b601f Compare June 15, 2022 09:18
@masseelch masseelch force-pushed the versioned/global-unique-id branch 2 times, most recently from 7142c03 to bef944e Compare June 15, 2022 12:27
@masseelch masseelch force-pushed the versioned/global-unique-id branch from bef944e to 85f1948 Compare June 15, 2022 12:32
a8m
a8m approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the code but can't see WithDeterministicGlobalUniqueID. It's too long for me 🙈

@masseelch masseelch merged commit 7017cbc into master Jun 15, 2022
@masseelch masseelch deleted the versioned/global-unique-id branch June 15, 2022 14:10
@timoha timoha mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a8m a8m a8m approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Versioned migrations do not work with GlobalUniqueID

4 participants

@masseelch @olagziel @a8m