Thanks to visit codestin.com
Credit goes to github.com

Skip to content

entc/gen: allow opening and testing concurrent enttest clients #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a8m merged 1 commit into from
Jun 20, 2022
Merged

entc/gen: allow opening and testing concurrent enttest clients #2665

a8m merged 1 commit into from
Jun 20, 2022

Conversation

@a8m
Copy link
Member

@a8m a8m commented Jun 19, 2022 •
edited
Loading

image

Fixed #2662

@a8m a8m force-pushed the enttest/parallel branch 3 times, most recently from 77b4ae6 to 10d5220 Compare June 19, 2022 18:11
@a8m a8m force-pushed the enttest/parallel branch from 10d5220 to 373bec7 Compare June 19, 2022 18:14
@masseelch masseelch self-requested a review June 19, 2022 19:21
@tmc
Copy link
Contributor

tmc commented Jun 19, 2022

This change looks reasonable to me. Nice wall time speed up!

@a8m a8m merged commit 311d760 into master Jun 20, 2022
@a8m a8m deleted the enttest/parallel branch June 20, 2022 05:32
@timoha timoha mentioned this pull request Oct 7, 2022
Closed
@a8m a8m mentioned this pull request Jul 11, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masseelch masseelch Awaiting requested review from masseelch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enttest.Open is not goroutine-safe

3 participants

@a8m @tmc