dialect/sql/schema: atlas engine is now default #2698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
718ea11 to
e8ba203
Compare
a8m
reviewed
Jul 4, 2022
e8ba203 to
fd04ef9
Compare
fd04ef9 to
3214083
Compare
a8m
approved these changes
Jul 4, 2022
Member
a8m
left a comment
There was a problem hiding this comment.
This is fantastic 🚀
My only concern is the BC for schemas that rely on the generated code (e.g. privacy or hooks) and won't be able to compile and execute the codegen. I'll check this on your branch.
| // MigrateOption allows for managing schema configuration using functional options. | ||
| type MigrateOption func(*Migrate) | ||
| // MigrateOption allows configuring Atlas using functional arguments. | ||
| type MigrateOption func(*Atlas) |
Member
There was a problem hiding this comment.
I saw that you updated also NewMigrate, so that should not break users' code, but I'll verify it locally and update you.
masseelch
commented
Jul 4, 2022
6dee083 to
bdb089e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
ModeInspectto inspect a connect database (legacy behavior)ModeReplayto replay the migration directory and then inspectAmong other things, the recently introduced
ent_typesfile for versioned migrations has been removed and the source of truth is now the inspected database.