Hey @adayNU 👋

A small comment on this behavior, the x NOT IN (...) operator is equivalent to NOT (x IN (...)). Hence, the predicate should be true and not false in the case of an empty set. Thoughts?

The SQL standard requires at least one value, but SQLite allows this:

sqlite> select 1 in ();
0
sqlite> select 1 not in ();
1

This bug currently prevents anyone using NotIn() from upgrading from v0.10.x to v0.11.x.

Can you elaborate on why?

@a8m sorry for the delay here. Updated based on your feedback.

So for the first question - this is obviously correct lol. I (naively) compared the output of client.Debug from v0.10.x and v.0.11.x and saw the difference was that v0.10.x had the FALSE keyword. So fwiw, it looks like this was also a bug in v0.10.x, just a different one :) (in v0.11.x you end up with an invalid query, in v0.10.x you end up with a silent bug).

For the latter question, given the statement above, it doesn't really feel like a major blocker given it was incorrect in both versions and you can workaround it in v0.11.x by simply ensuring you don't call NotIn() w/o arguments.

Thanks for the contribution @adayNU 🙏🏻