entc/gen: allow package with alias on ID field #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
d8d31f7 to
0c5e260
Compare
a8m
reviewed
Sep 13, 2022
0c5e260 to
286559e
Compare
giautm
reviewed
Sep 16, 2022
giautm
approved these changes
Sep 16, 2022
Collaborator
giautm
left a comment
There was a problem hiding this comment.
Tested with my reproduce the bug. It removes the duplicate import.
Co-authored-by: Giau. Tran Minh <[email protected]>
Member
|
Thanks, @crossworth ❤️🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, was reported in Discord 1, 2, that it's not possible to use
github.com/oklog/ulid/v2as aUUIDtype.The example using
ent/bugworked correctly, but after updating to the latest version a problem with duplicated imports (one with the alias and the other without) occurs.This seems related to #2765 (could not test it).
Any way this PR tries to solve this problem, it also adds a test for the problem of #2761 to ensure we don't get a regression.
NOTE:
ent/bugto use the latest version of Ent.entgenfolder is to be able to debug the code, let me know if I should remove it.