docs/md: various fixes #2965
Merged
docs/md: various fixes #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without entgql.WithSchemaGenerator entc.go fails to run.
Note that the where:TodoWhereInput parameter is pre-filled in the generated ent.graphql file.
Only add for the first example to provide a lead to readers.
a8m
approved these changes
Sep 27, 2022
Member
a8m
left a comment
There was a problem hiding this comment.
💯
Appreciate the help, @kortschak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes that look like are needed. I have some doubts because some fixes here are added in later pages (notable example being the addition of
entgql.WithSchemaGenerator()to entc.go in doc/md/tutorial-todo-gql-filter-input.md, which is required to make entc.go successfulliy complete, but which is added in the tutorial in a later page, https://entgo.io/docs/tutorial-todo-gql-schema-generator — though there are others that I've found). My suspicion is that the page order has changed over the construction of the tutorial.Please take a look.