-
Notifications
You must be signed in to change notification settings - Fork 1k
entc cli command to remove generated code #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @paulvollmer, and thanks for your contribution! Super happy to see this contribution, and I'm going to review this tomorrow. Thanks! |
|
@a8m good to hear that the PR is welcome. at the moment the linter throw an error becasue the
i moved the |
|
Hey @paulvollmer, any update with this PR? |
|
Hi @a8m, i hadn't time the last weeks to work on the feature but now i implemented the fileWalk. i do the following: walk over the input path and delete all .go files with the header after that walk i do a second walk to delete the empty directories ( |
44b6712 to
458cf91
Compare
ea43576 to
6c62ea5
Compare
|
@a8m after a long break at this pr i solved the merge conflict. what do you think about refactoring the I prefer the second option because it is much more cleaner. |
|
@luantranminh @a8m i have solved the merge conflicts and the PR is now ready to get merged. |
|
What is blocking this merge? |
|
Thanks for this contribution @paulvollmer, it's really appreciated. I decided to have this logic enabled by default instead of adding a new command to |
|
You make my dreams come true, @a8m. 😄 |
hello,
i added a command to the
entccli to remove the generated files from the given directory. for thecleancommand the path it is not theent/schemadirectory (as it is forentc generatebecause it will also delete theclient.go,config.goetc. files.the command will read the
schemadirectory and create a list of files that need to be removed based on the files found at the directory.