Codestin Search App

epezent · 2021-03-29T06:02:19Z

This PR extends the work of @ozlb's aligned plots #144. It adds a new API for creating both 1D and 2D sublots with automatic alignment along rows and columns. I expect this PR to be a WIP for a few weeks, as I want to make subplots a first-class feature and I have several ImPlotSubplotFlags_ options in mind for them.

Looping in interested parties and regulars: @yaman, @peterwilson136, @Mrgoodbytes13, @arximboldi, @ocornut, @bear24rw, @jvannugteren, @mindv0rtex, @PeterJohnson, @hoffstadt

What features would you like to see in a subplot API? How could this be more useful than plots inside of ImGui tables?

Current API prototype (feel free to try, but very rough at the moment). Usage is a simple a matter of surrounding rows*cols calls to Begin/EndPlot inside of Begin/EndSubplot. Plots are arranged in row-major order. Currently it is not possible to plot out of order (and I don't see an easy path forward for that). IDs are handled behind the scenes, so no need to Push/Pop IDs or use different titles. The ImVe2 size parameter of BeginPlot is ignored when inside of a Subplot context, as the size is determind from the parameter passed to BeginSubplot. Otherwise, everything else is the same as using BeginPlot.

ImGui::Begin("Subplots Test");
if (ImPlot::BeginSubplot("Subplots", 3, 3, ImVec2(800,600))) {
    for (int i = 0; i < 9; ++i) {
        if (ImPlot::BeginPlot("Subplot","X","Y") {
            ...
            ImPlot::EndPlot();
        }
    }
    ImPlot::EndSubplot();
}
ImGui::End();

new signature ID, ImPool to store padding data, demo

vertical will align Y axis, horizontal will align X axis. *signature changed

#144 (comment)

yan-zaretskiy · 2021-03-29T13:47:22Z

Two things that come to mind:

Linked axes, both x and y. I saw it in the AlignedPlots: Y/X axis padding over multiple plots #144, so it's probably already supported.
Common title. The title string at the top of the subplot grid.

peterwilson136 · 2021-03-29T20:57:11Z

Some things also, (they might be a bit pedantic)

Multi line titles and labels for axis
Right hand side Y axis labels
Control over the scale of the axes, ie, instead of 1+e06, something such as 1m
Perhaps this might be a tricky one, but when you use ImPlotAxisFlags_Time, can there be another flag that (if specific days are skipped), the plot continues on as if its the next day from when there was a gap., ie,
1 2 3 7 8 9 11... but representing specific dates / times on the axis? Edit - This would be for something like hours worked in a week, say mon-fri, sat + sun are skipped so have a continuous x-axis of mon-fri for each week.

epezent · 2021-03-30T05:42:01Z

@mindv0rtex, I added two flags ImPlotSubplotFlags_LinkRows and ImPlotSubplotFlags_LinkCols that can enable axis linking:

bear24rw · 2021-03-31T16:15:42Z

One thing that would be super useful for my application is the ability to resize the rows and columns. I currently achieve this in my app by using an invisible button between the plots as demonstrated here.

This currently works "okay" but i have the issue of time alignment if the y ticks change width on one of the plots which this branch aims so solve:

EDIT: Simply using ImPlot::BeginAlignedPlots in my application "just worked" :) The ability for implot to provide the plot resizing feature as a built-in is less important to me now that I can achieve alignment.

epezent · 2021-06-18T04:26:04Z

Some new features to report:

titles
shared legends and items
draggable splitters

PeterJohnson · 2021-06-18T04:54:11Z

This looks amazing! Can the split locations be read / initialized? (I have an application where we need to persist the user-edited layout across application restarts).

epezent · 2021-06-18T05:02:54Z

Yes, that's what I'm planning. It's not currently implemented in full, but:

IMPLOT_API bool BeginSubplots(const char* title_id,
                             int rows,
                             int cols,
                             const ImVec2& size,
                             ImPlotSubplotFlags flags = ImPlotSubplotFlags_None,
                             float* row_sizes = NULL,
                             float* col_sizes = NULL);

You can set row and col sizes by passing arrays as optional args. These are percentages of total plot width/height, so each array sums to 1. If the user manipulates the splitters, these arrays will be updated and returned as an out paramter.

…ap in BeginSubplots(). (epezent#203) Likely this was pulled from SplitterBehavior(), where it made senses but only given the possibility user would call SetItemAllowOverlap() after. AFAIK after debugging the code I _think_ this has no meaningful side-effect. Also removed same thing in Tables code in core lib. Flag added in epezent@4a1ee88.

…ap in BeginSubplots(). (#203) Likely this was pulled from SplitterBehavior(), where it made senses but only given the possibility user would call SetItemAllowOverlap() after. AFAIK after debugging the code I _think_ this has no meaningful side-effect. Also removed same thing in Tables code in core lib. Flag added in 4a1ee88.

…ap in BeginSubplots(). (epezent#203) Likely this was pulled from SplitterBehavior(), where it made senses but only given the possibility user would call SetItemAllowOverlap() after. AFAIK after debugging the code I _think_ this has no meaningful side-effect. Also removed same thing in Tables code in core lib. Flag added in epezent@4a1ee88.

* SubPlots: Y axis padding over multiple plots * Align Plots Group new signature ID, ImPool to store padding data, demo * Align plots orientation (vertically, horizontally) vertical will align Y axis, horizontal will align X axis. *signature changed * ImPlotOrientation used as flag for 2D grids of aligned plots epezent#144 (comment) * AlignPlots updates to merge with v.0.9 * Sync to v0.9 20210127 * subplots proto * make link flags work * stuff * add multi-line centered titles * subplots work * flag ideas * better subplot positioning * resizable subplots * subplot shared items * subplot ratios * some cleanup and refactor * some cleanup and refactor * refactors and demo reorganization * context menus...almost done! * context menus, bug fixes * active id * make implot use ButtonBehavior throughout * bug fixes * more bug fixes * tweaks * fix id issue * finish work on subplots Co-authored-by: ozlb <[email protected]>

…ap in BeginSubplots(). (epezent#203) Likely this was pulled from SplitterBehavior(), where it made senses but only given the possibility user would call SetItemAllowOverlap() after. AFAIK after debugging the code I _think_ this has no meaningful side-effect. Also removed same thing in Tables code in core lib. Flag added in epezent@4a1ee88.

ozlb and others added 10 commits November 9, 2020 20:27

SubPlots: Y axis padding over multiple plots

9c92f8b

Align Plots Group

066c60d

new signature ID, ImPool to store padding data, demo

Align plots orientation (vertically, horizontally)

0857ece

vertical will align Y axis, horizontal will align X axis. *signature changed

ImPlotOrientation used as flag for 2D grids of aligned plots

2afebb0

#144 (comment)

AlignPlots updates to merge with v.0.9

0f62978

Merge branch 'master' into SubPlots

39dfb5b

Sync to v0.9 20210127

e125749

Merge branch 'master' into SubPlots

0a3d0cc

tidy update AlignedPlots

e6e530f

subplots proto

5116ce2

make link flags work

9898e2e

epezent added 2 commits March 30, 2021 16:19

stuff

cec3934

add multi-line centered titles

7352176

epezent and others added 6 commits April 7, 2021 20:00

subplots work

4e5bfdb

add a few more subplot flags

5a2a380

flag ideas

8a7ef0b

better subplot positioning

673fbcf

resizable subplots

88e9489

subplot shared items

29b467e

epezent mentioned this pull request Jun 18, 2021

implot for Geoscience #248

Open

epezent added 3 commits June 18, 2021 07:50

subplot ratios

df57bd4

some cleanup and refactor

9095431

some cleanup and refactor

893628a

epezent added 10 commits June 18, 2021 23:45

refactors and demo reorganization

439da77

context menus...almost done!

c561592

context menus, bug fixes

27bda62

active id

1a5d2b7

make implot use ButtonBehavior throughout

4a1ee88

bug fixes

09d8ef1

more bug fixes

a45975a

tweaks

b58ca9d

fix id issue

833cb3b

finish work on subplots

273b4f7

epezent merged commit 8c1bbf4 into master Jul 8, 2021

epezent mentioned this pull request Jul 8, 2021

AlignedPlots: Y/X axis padding over multiple plots #144

Closed

epezent deleted the subplots branch July 8, 2021 05:19

calcmogul mentioned this pull request Oct 1, 2023

Look into new implot subplots and linked axis features wpilibsuite/allwpilib#5705

Open

ocornut mentioned this pull request Jun 28, 2023

Fixes for AllowOverlap and internal changes in 1.89.7 #486

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subplots#203

Subplots#203
epezent merged 32 commits intomasterfrom
subplots

epezent commented Mar 29, 2021

Uh oh!

yan-zaretskiy commented Mar 29, 2021

Uh oh!

peterwilson136 commented Mar 29, 2021 •

edited

Loading

Uh oh!

epezent commented Mar 30, 2021

Uh oh!

bear24rw commented Mar 31, 2021 •

edited

Loading

Uh oh!

epezent commented Jun 18, 2021

Uh oh!

PeterJohnson commented Jun 18, 2021

Uh oh!

epezent commented Jun 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

epezent commented Mar 29, 2021

Uh oh!

yan-zaretskiy commented Mar 29, 2021

Uh oh!

peterwilson136 commented Mar 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

epezent commented Mar 30, 2021

Uh oh!

bear24rw commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

epezent commented Jun 18, 2021

Uh oh!

PeterJohnson commented Jun 18, 2021

Uh oh!

epezent commented Jun 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

peterwilson136 commented Mar 29, 2021 •

edited

Loading

bear24rw commented Mar 31, 2021 •

edited

Loading