Add covariant List and Option to the library #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-bucev
commented
Apr 25, 2023
|
|
||
| protected def keep(tr: ast.Trees)(fd: tr.FunDef): Boolean = fd match { | ||
| case fd if fd.flags.exists(_.name == "unchecked") => false | ||
| case fd if fd.flags.exists(f => f.name == "unchecked" || f.name == "synthetic") => false |
Collaborator
Author
There was a problem hiding this comment.
Synthetic functions are filtered out before being passed to the type checker when using the usual filter. Since the LibrarySuite is using a custom filter, removing synthetic option was also intended?
Collaborator
Author
There was a problem hiding this comment.
For context, the type checker says that ObjectPrimitiveSize does not have visibility on Object (since it is mutually recursive with it - probably due to the encoding of ::).
d01d3d9 to
1773647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @vkuncak.
Removes the
CovariantListbenchmark since it is now in the library.